Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config to disable gpio button internal pull resistor (AEGHB-917) #447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dengber
Copy link

@dengber dengber commented Dec 15, 2024

When there is a external pull up / down resistor, we don't need the internal pull resistor, so we need a way to disable the internal pull resistor.

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Dec 15, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello dengber, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5f88d71

@github-actions github-actions bot changed the title add config to disable gpio button internal pull resistor add config to disable gpio button internal pull resistor (AEGHB-917) Dec 15, 2024
@leeebo leeebo added the button label Dec 19, 2024
@lijunru-hub
Copy link
Contributor

@leeebo LGTM, please sync it to the internal MR.

@leeebo
Copy link
Collaborator

leeebo commented Dec 25, 2024

@dengber thanks for your contribution, would you please change the version to 3.5.0 in https://github.com/espressif/esp-iot-solution/blob/master/components/button/idf_component.yml#L1 (We consider the configuration change as a break change; thus, a new minor version is required for release. ), and please add the change log to https://github.com/espressif/esp-iot-solution/blob/master/components/button/CHANGELOG.md

@dengber
Copy link
Author

dengber commented Dec 27, 2024

@leeebo I changed the version to 3.5.0 and added the change log.

@leeebo
Copy link
Collaborator

leeebo commented Dec 30, 2024

sha=dddbedb22b0d235eaa033e130bd379f7f6d88fea

@leeebo
Copy link
Collaborator

leeebo commented Dec 30, 2024

@dengber Thanks!

finally, please install pre-commit and re-commit to ensure the code adheres to standards and passes internal CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants